Skip to content

Type improvements to landing.py and panel.py #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Type improvements to landing.py and panel.py #960

wants to merge 5 commits into from

Conversation

VasigaranAndAngel
Copy link
Collaborator

Summary

  • few type improvements to both landing.py and panel.py
  • renamed a method in the PanelModal class (in panel.py) and updated all references in other files

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

Computerdores
Computerdores reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I the comments I added aren't issues with what you did, but issues with the code you touched that might as well be fixed now while the code is being changed anyways

@CyanVoxel CyanVoxel added the Type: Refactor Code that needs to be restructured or cleaned up label Jun 13, 2025
@CyanVoxel CyanVoxel moved this to 👀 In review in TagStudio Development Jun 13, 2025
Computerdores
Computerdores reviewed Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry if this was unclear, but what I intended to say was that both the title and the window title could be moved to the constructor.
Unless it was clear enough and you didn't do it for another reason?

@Computerdores Computerdores moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jun 17, 2025
@Computerdores Computerdores moved this from 🍃 Pending Merge to 👀 In review in TagStudio Development Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computerdores Computerdores Computerdores left review comments

Assignees
No one assigned
Labels
Type: Refactor Code that needs to be restructured or cleaned up
Projects
TagStudio Development
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VasigaranAndAngel @Computerdores @CyanVoxel